Skip to content

Conversation

@phdargen
Copy link
Contributor

@phdargen phdargen commented Jan 8, 2026

Description

  • Adds discovery extension
  • Removes null fields like "body_fields":null,"header_fields":null from output_schema for legacy fastapi/flask, closing FastAPI Input Schema not resolved by x402scan #862 and doesn't repeat the same mistake for v2
  • removes legacy mainnet example
  • removes unused code in e2e tests

Tests

🔍 Running Bazaar Discovery Validation...


╔════════════════════════════════════════════════════════╗
║         Bazaar Discovery Extension Validation          ║
╚════════════════════════════════════════════════════════╝

📋 Expected Discoverable Endpoints: 5

═══════════════════════════════════════════════════════
                 Discovery Summary
═══════════════════════════════════════════════════════
Total Facilitators:          1
Facilitators with Bazaar:    1
Expected Endpoints:          5
Total Discovered Resources:  5

📍 typescript:
   Discovered: 5/5
   ✅ All expected endpoints discovered

═══════════════════════════════════════════════════════
✅ Discovery Validation: PASSED
═══════════════════════════════════════════════════════


🧹 Cleaning up...
  🛑 Stopping facilitator: typescript

📊 Test Summary
==============
✅ Passed: 7
❌ Failed: 0
📈 Total: 7

📋 Detailed Test Results
========================

✅ PASSED TESTS:

  # 1: httpx → fastapi → /protected
      Facilitator: typescript | Network: eip155:84532 | Tx: 0x818d301e...
  # 2: httpx → fastapi → /protected-2
      Facilitator: typescript | Network: eip155:84532 | Tx: 0x5f526afb...
  # 3: httpx → fastapi → /protected-svm
      Facilitator: typescript | Network: solana:EtWTRABZaYq6iMfeYKouRu166VU2xqa1 | Tx: 4T3SvMp2ZB...
  # 4: requests → fastapi → /protected
      Facilitator: typescript | Network: eip155:84532 | Tx: 0xbb75e851...
  # 5: requests → fastapi → /protected-svm
      Facilitator: typescript | Network: solana:EtWTRABZaYq6iMfeYKouRu166VU2xqa1 | Tx: 5jtEnCku7S...
  # 6: httpx → flask → /protected
      Facilitator: typescript | Network: eip155:84532 | Tx: 0x5f71641c...
  # 7: httpx → flask → /protected-svm
      Facilitator: typescript | Network: solana:EtWTRABZaYq6iMfeYKouRu166VU2xqa1 | Tx: 2PBB8sfW5z...

📊 Breakdown by Facilitator:
   typescript      ✅ 7 / ❌ 0 (100%)

📊 Breakdown by Server:
   fastapi              ✅ 5 / ❌ 0 (100%)
   flask                ✅ 2 / ❌ 0 (100%)

📊 Breakdown by Client:
   httpx                ✅ 5 / ❌ 0 (100%)
   requests             ✅ 2 / ❌ 0 (100%)

📊 Protocol Family Breakdown:
   EVM: ✅ 4 / ❌ 0 / 📈 4 total
   SVM: ✅ 3 / ❌ 0 / 📈 3 total

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits

@vercel
Copy link

vercel bot commented Jan 8, 2026

@phdargen is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added sdk Changes to core v2 packages examples Changes to examples python legacy Changes to legacy sdk or examples labels Jan 8, 2026
@phdargen phdargen marked this pull request as draft January 8, 2026 15:21
@phdargen phdargen marked this pull request as ready for review January 8, 2026 16:15
Copy link
Contributor

@CarsonRoscoe CarsonRoscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@CarsonRoscoe CarsonRoscoe merged commit 1c5a2c1 into coinbase:feat/python-v2-sdk Jan 8, 2026
13 of 14 checks passed
@Ilevk
Copy link

Ilevk commented Jan 10, 2026

it would be helpful to implement advanced server example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples Changes to examples legacy Changes to legacy sdk or examples python sdk Changes to core v2 packages

Development

Successfully merging this pull request may close these issues.

3 participants