feat: improved text input

coingaming · Nov 9, 2021 · 4ab45b6 · 4ab45b6
1 parent d2d7868
commit 4ab45b6
Show file tree

Hide file tree

Showing 5 changed files with 83 additions and 287 deletions.
diff --git a/lib/moon/components/select.ex b/lib/moon/components/select.ex
@@ -45,9 +45,6 @@ defmodule Moon.Components.Select do
       options={options_with_selected}
       opts={[prompt: @prompt]}
     />
-    <Surface.Components.Context get={Surface.Components.Form, form: form}>
-      <ErrorTag field={@field} :if={form} />
-    </Surface.Components.Context>
     """
 
     ~F"""

diff --git a/lib/moon/components/text_input.ex b/lib/moon/components/text_input.ex
@@ -3,7 +3,6 @@ defmodule Moon.Components.TextInput do
 
   use Moon.StatelessComponent
   alias Moon.Components.Label
-  alias Moon.Components.ErrorTag
 
   prop field, :atom
   prop label, :string
@@ -73,14 +72,13 @@ defmodule Moon.Components.TextInput do
         opts={
           placeholder: @placeholder,
           disabled: @disabled,
-          required: @required,
+          required: @required && !@disabled,
           type: @type
         }
         value={@value}
         focus={@focus}
         blur={@blur}
       />
-      <ErrorTag field={@field} />
     </div>
     """
 

diff --git a/lib/moon_web/components/example_and_code.ex b/lib/moon_web/components/example_and_code.ex
@@ -18,7 +18,7 @@ defmodule MoonWeb.Components.ExampleAndCode do
 
   def render(assigns) do
     ~F"""
-    <div class={"rounded-lg p-0 mb-8 #{@class}"}>
+    <div class={"rounded p-0 mb-8", @class}>
       <PreviewCodeButton
         class="justify-end"
         title={@title}