[MDS-188] Create the InputGroup component #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide the HintText div if not supplied for text input
theycallmehero
requested changes
Aug 24, 2022
There was a problem hiding this comment.
Hey!
I see that a lot of good work was done in this PR, so good effort! :)
I have a feeling, that few things can be made more simple (with less code for developer, who is using this library) - I will come back with improvement ideas as a code improvements today or tomorrow. :)
Sorry for delaying merge of this PR. Good work as a first step! :) 👍
theycallmehero
approved these changes
Sep 2, 2022
theycallmehero
approved these changes
Sep 2, 2022
alexisdevtailor
added a commit
that referenced
this pull request
Sep 2, 2022
theycallmehero
pushed a commit
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.