Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sorting icon for table update [MDS-971] #825

Conversation

salvatorecriscioneweb
Copy link
Contributor

@salvatorecriscioneweb salvatorecriscioneweb commented Jan 23, 2024

Issue:

Sorting icon is wrong, we need to use by default chevron-small, plus I added the possibility to customize it in case needed.

API Changes:

  • Is possible to customize the color using the text-* class, sorting_icon_color is added to cover it, by default is set to bulma for Moon.Parts , in the design is unset
  • Is possible to customize the icon using the sorting_icon prop, by default controls_chevron_up_small
    note:
    You need to specify only the up icon, the down icon is rendered by rotating the up by 180deg

Default:

Screenshot 2024-01-23 at 12 06 42

Example:

sorting-icon

@salvatorecriscioneweb salvatorecriscioneweb marked this pull request as draft January 23, 2024 09:56
@salvatorecriscioneweb salvatorecriscioneweb marked this pull request as ready for review January 23, 2024 10:07
@salvatorecriscioneweb salvatorecriscioneweb merged commit 29b4446 into main Jan 29, 2024
2 checks passed
@salvatorecriscioneweb salvatorecriscioneweb deleted the salvatorecriscioneweb/MDS-971-wrong-icon-for-sorting-table branch January 29, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants