Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add documentation and plugin publishing commands #8

Merged
merged 10 commits into from
Dec 4, 2023

Conversation

maaarcelino
Copy link
Contributor

As a follow up to #7 this PR adds code to publish this plugin to the Cloudquery Hub.

One of the new requirements is that plugin documentation live in the docs/overview.md file. I've moved a chunk of the README into this new file. I also modified the documentation generation to use the cloudquery tables CLI command and added an option for controlling the concurrency of a sync.

@maaarcelino
Copy link
Contributor Author

CC @mbillewicz @r--w

@mbillewicz
Copy link
Collaborator

mbillewicz commented Nov 9, 2023

@maaarcelino
Looks good, could you generate files due to failing check?
Should I after merge publish plugin to cloudquery hub?

@maaarcelino
Copy link
Contributor Author

@mbillewicz Done.

We'll take care of the initial publish. I've created a team for you on our Hub. Can you give me an email address for you/someone on your side so I can transfer the ownership? You can share it here or email me at marcel@cloudquery.io.

@mbillewicz
Copy link
Collaborator

@maaarcelino pls use it@coinpaprika.com

@maaarcelino
Copy link
Contributor Author

@mbillewicz I've sent you an invite. Can you merge this PR, please?

@mbillewicz
Copy link
Collaborator

@maaarcelino nothing in inbox, could you send once again?

@r--w r--w merged commit 570fe0e into coinpaprika:master Dec 4, 2023
1 check passed
@maaarcelino
Copy link
Contributor Author

@mbillewicz I just resent it.

@r--w
Copy link
Member

r--w commented Dec 5, 2023

@maaarcelino what is the title of the email? I can't find it in my inbox, checked both main and spam folders for it@coinpaprika.com email.

@maaarcelino
Copy link
Contributor Author

@r--w Apologies, I just found out that we haven't implemented the email feature for user invites. Can you register for an account using it@coinpaprika.com here https://cloud.cloudquery.io/auth/register? Once you have an account you'll see the invite in the UI.

@r--w
Copy link
Member

r--w commented Dec 8, 2023

@maaarcelino I've created account, but can't see coinpaprika project and seems that name is already taken ;)
I created coinpaprika_com project instead. Could you link both projects somehow?
SCR-20231208-kqkx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants