Split workflow into PR and nightly #146
Conversation
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
| status: 'success' | ||
| if: success() && github.event_name == 'schedule' | ||
|
|
||
| double_test: |
There was a problem hiding this comment.
what is "double" test and how is it not handled by the matrix in ros1_tests
There was a problem hiding this comment.
I'm not quite sure what it does; the purpose of this PR was to improve the GitHub workflow by refactoring what we currently have.
I've opened the issue: #148 to resolve this
There was a problem hiding this comment.
all right - i see now that this is a full duplicate of the PR one plus cloudwatch. it feels really fragile to be completely duplicated with one difference, let's move forward as long as you're brainstorming how to deduplicate
There was a problem hiding this comment.
I think I can skip steps using if, opening a PR to test this
There was a problem hiding this comment.
Opened PR #149 which skips AWS configuration instead of duplicating work. I'll close this PR out if that workflow is working and its agreed upon that its a better solution.
There was a problem hiding this comment.
@zmichaels11 @emersonknapp See the .travis.yml to understand what each of these tests are doing. Each one is matrix of the tests using a specific Docker build.
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
|
Closing in favor of PR #149 which does the same thing, but without duplicating code. |
Changes
Signed-off-by: Zachary Michaels zmichaels11@gmail.com