Add sysconfig scheme workaround for osx_framework_library #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The homebrew folks took a similar approach to Debian's patch, but it's
worse because their `purelib` completely disregards `{prefix}` entirely,
meaning that colcon is attempting to install stuff into Homebrew's
prefix path.
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 81.70% 81.70%
=======================================
Files 60 60
Lines 3564 3564
Branches 684 684
=======================================
Hits 2912 2912
Misses 601 601
Partials 51 51
Continue to review full report at Codecov.
|
sloretz
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Homebrew folks took a similar approach to Debian's patch, but it's worse because their
purelibcompletely disregards{prefix}entirely, meaning that colcon is attempting to install stuff into Homebrew's prefix path.See https://github.com/Homebrew/homebrew-core/blob/2f008323193f636d32c4a970caa9e8b528c6c430/Formula/python%403.10.rb#L62-L68