Skip to content

Commit

Permalink
Add support for windows (#18)
Browse files Browse the repository at this point in the history
* Add windows support

Signed-off-by: Chen Bainian <chenbn@artc.a-star.edu.sg>

* Use environ for Windows too
  • Loading branch information
Briancbn authored Nov 23, 2021
1 parent 2329ecb commit 1f54df4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion colcon_ed/edit_tools/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ def edit_target_file(path):
editor = os.environ.get('EDITOR', 'vim')
if not editor:
editor = 'vim'
process = subprocess.Popen([editor, path])
process = subprocess.Popen([editor, path],
shell=(os.name == 'nt'))
while process.returncode is None:
try:
process.communicate()
Expand Down

0 comments on commit 1f54df4

Please sign in to comment.