Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass file object where it makes sense for announced interceptions #38

Open
grantcopley opened this issue Jan 5, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@grantcopley
Copy link
Contributor

The file object was created after we added announced interceptions for various file operations.

For example, consider the cbfsOnFileCreate interception. The listener signature looks like this.

function cbfsOnFileCreate( path, contents, visibility, metadata, overwrite, mode, disk ) {

}

This can be greated simplified now that we have a file object that pass around.

function cbfsOnFileCreate( file ) {

}
@grantcopley grantcopley added the enhancement New feature or request label Jan 5, 2023
@grantcopley grantcopley self-assigned this Jan 5, 2023
@grantcopley grantcopley added this to the v1.1 milestone Jan 24, 2023
@grantcopley grantcopley added the good first issue Good for newcomers label Jan 24, 2023
jclausen added a commit that referenced this issue Jan 26, 2023
#38 Pass file object where it makes sense for announced interceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant