Skip to content

php7 + apache2 fix #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

php7 + apache2 fix #25

wants to merge 4 commits into from

Conversation

commercebyte
Copy link

No description provided.

root and others added 3 commits March 12, 2016 22:42
@colder
Copy link
Owner

colder commented Mar 15, 2016

I just pushed a fix for a build warning to topic/fix-segfault. Can you confirm that this new version works as expected on your end? As soon as you do I will merge and release.

https://github.com/colder/php-weakref/tree/topic/fix-segfault

@commercebyte
Copy link
Author

Installed, looks like it works fine, thanks for cleaning up!

Jim Zubov
CommerceByte Consulting
President

On March 15, 2016 6:11:39 AM EDT, Etienne Kneuss notifications@github.com wrote:

I just pushed a fix for a build warning to topic/fix-segfault. Can you
confirm that this new version works as expected on your end? As soon as
you do I will merge and release.

https://github.com/colder/php-weakref/tree/topic/fix-segfault

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#25 (comment)

wr_store.c:
c6f1d11 
old_dtors it actually holds zend_object_dtor_obj_t's, not zval's, so Z_PTR_P() didn't do any good
@commercebyte
Copy link
Author

I found a problem, pushed a fix, see comment on commit -

Jim Zubov
CommerceByte Consulting
President

On March 15, 2016 6:11:39 AM EDT, Etienne Kneuss notifications@github.com wrote:

I just pushed a fix for a build warning to topic/fix-segfault. Can you
confirm that this new version works as expected on your end? As soon as
you do I will merge and release.

https://github.com/colder/php-weakref/tree/topic/fix-segfault

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#25 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@commercebyte @colder