-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tray icon on Wayland #199
Comments
Hi, I have little experience with wayland, but I will try to check up whether I can reproduce this during the weekend. Do you have any issues with other applications displaying tray icons? Is this an actual crash (program terminates) or is it just some message appearing as output? Best, Thomas |
I don't have issues with other tray icons (udiskie is the only GTK-based one though). Apart from the tray udiskie seems to work. At least it isn't crashing, only the warning is produced and no tray icon is displayed. |
I have now tried running sway+waybar, and I could reproduce your problem, but I also had a bad experience apart from that:
It could be related to this comment from the swaywm wiki:
udiskie implements tray using GtkStatusIcon as well as AppIndicator3 (using the Therefore, I'm sorry that this is a wontfix from my side so far, but if you happen to figure out the problem, I'm happy to accept a pull-request or hints for patching. Best, Thomas |
I came for the same issue, as I'm getting the same error on sway:
|
Hi, same issue brought me here
Works! Just make sure you have |
thanks @soyuka! After your comment, I realized the @Weishaupt @robertjk Can you confirm that this works for you as well? Best, Thomas |
Remove the need to specify `--tray` additionally. This is likely to have caused some confusion, see e.g. #199.
Thanks for the update. I have seen similar issues with the udiskie menu not displaying correctly when using the appindicator within my usual environment. For some reason, it seems to work under sway (but only after clicking two or three times), while another application (kalu) shows the same erroneous behaviour there. I will leave this open for now and investigate a bit, but I can't promise that I will figure something out. |
I'm running Sway and the above screenshot is from Waybar ran in Sway. Cool, let's leave it open and maybe at some point it'll get fixed. Thanks for help! |
One part of the issue seems to be that a call to However the situation is still not resolved, because I noticed that the handler which is supposed be called after the user clicks the icon, before the menu is shown, never gets called, and therefore doesn't update the menu. I also noticed that the following message appears when using appindicator:
Can't trace this so far. |
Update on my interim findings, mostly for future-me: For lack of a proper mechanism in the AppIndicator3 AP itself,
Today, this signal:
Furthermore, via this signal and IMO, AppIndicator is utterly broken because
So, I searched a bit for alternatives, and found the following:
Long term solution may be to migrate udiskie to Qt where more reliable alternatives are available (QSystemTrayIcon/KStatusNotifierItem) that should work with waybar while supporting all features that are needed. Also, I have some quarrels with gtk3+ regarding menus, ease-of-use, and their history of deprecating useful features It's not just me, others seem to despise appindicator as well, some references: |
Wow, it seems you did quite a research. Respect 🙇♂️ . |
Hi, I just started using udiskie under wayland. Cool project! If you need testing I'd be glad to help :) |
You can add |
I am having an issue with the tray as well on sway
Tested with both appindicator on and off, same behaviour on both 2.2 and 2.1. |
Hello coldfix, Would you please adjust it to work without This line should definitely be changed: Line 380 in d7b95ae
|
Hi @tiosgz, ok. I agree that something definitely has to change about wayland support. I currently don't have much time. Might have some time next weekend. Otherwise feel free to submit PRs. Best, Thomas |
FYI, I have added a workaround that should hopefully display the tray menu correctly from now on, at the (minor) cost of moving the device list into a submenu. |
I'm have error message and icon udiskie not present in tray. `udiskie -t (udiskie:4248): Gtk-CRITICAL **: 09:26:44.847: gtk_widget_get_scale_factor: assertion 'GTK_IS_WIDGET (widget)' failed` `community/udiskie 2.4.2-1 [установлен] Removable disk automounter using udisks` OS: Arch Linux x86_64 |
I'm trying to run udiskie with a tray icon on wayland, but this fails with the following error
My setup
The text was updated successfully, but these errors were encountered: