Fix missing financial_account_id for recurring contributions #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitendrapurohit
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
Tested by different combinations of amounts on the webform and this works as expected. Thanks @mattwire
|
I think the fix actually needs to be in CiviCRM core as this won't work with multiple line items - see civicrm/civicrm-core#26974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Both
price_field_idandprice_field_value_idneed to be set when creating the lineitems.For memberships we were retrieving that data but not using it. For contributions we were only retrieving the default
price_field_idand not settingprice_field_value_id.This resulted in errors such as found in https://lab.civicrm.org/extensions/mjwshared/-/issues/20 where CiviCRM ends up not setting the financial_account_id.
Before
"Invalid" lineitems created.
After
Valid lineitems created.
Technical Details
CiviCRM has a default "Price field ID" and a default "Price field value ID" which should be used if nothing else is specified. For memberships we can map them to existing ones.
Comments