Migrate from compiletest_rs to trybuild #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One more recommendation how to test compiler failures. |
andy128k
force-pushed
the
trybuild
branch
2 times, most recently
from
12e8fa1 to
f132704
Compare
|
@TedDriggs Rustc constantly changes/improves output of compile errors. Now tests in master branch are broken in nightly. Upcoming release of Rust will break tests on stable/beta too. I propose to follow an advise of dtolnay and run them on a single version. Minimal supported version of compiler (for now it is 1.40.0) seems reasonable to me. Switching to |
|
@TedDriggs ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that compiletest_rs is unstable. You need to run
cargo cleanfrom time to time to make it work. Its error messages are unreadable. Also I noticed that it doesn't work on macos.Then I found this. 😏
I tested this on Linux and macos and it works well.