Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typecache was no longer used as of #1023 but we never fully removed it. So, an unnecessary
Map
was still being created per call toparse
orsafeParse
. This removes that call.Benchmarks: https://observablehq.com/d/b4b367792308cedb
Since this is a performance bump that just affects the top-level method, the impact on microtests is dramatic - like 20%+. For example, this code benefits dramatically:
There probably aren't that many people who have such small zod schemas in prod, but nevertheless… it was wasted memory and time and now it isn't.
There's still a very large gap between zod & myzod for primitives which I've having a tough time bridging, still working on that.