Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1001
Here is a codesandbox to illustrates the problem encountered: https://codesandbox.io/s/youthful-sunset-6jn810?file=/src/index.test.ts
An issue with instanceof schema should be fatal in order to prevent running refinement on a value which might be incompatible with the provided instance type.
This PR introduces an additional optional parameter in the
custom
signature to specify wether the issue should be fatal.However it would be better to specify it as an object to specify more options in the future.
Let me know if this PR needs improvements to meet the guidelines.