Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ZodString.date() & ZodString.time(). #1766

Merged
merged 20 commits into from
Apr 7, 2024

Conversation

igalklebanov
Copy link
Contributor

@igalklebanov igalklebanov commented Dec 27, 2022

Hey 👋

This PR resolves #1676, as suggested by @colinhacks @ comment.

  • implement ZodString.date().
  • implement ZodString.time().
  • unit tests.
  • documentation.

@netlify
Copy link

netlify bot commented Dec 27, 2022

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5328a97
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/65691e0ae916460008dbc2dd
😎 Deploy Preview https://deploy-preview-1766--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@igalklebanov igalklebanov marked this pull request as ready for review January 15, 2023 22:56
Copy link
Contributor

@maxArturo maxArturo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @igalklebanov I promise I'm not following you 😆 I'm just going down the PRs to check them out!

👍 LGTM, just a couple of comments you may want to consider!

deno/lib/README.md Outdated Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
igalklebanov and others added 3 commits January 20, 2023 15:20
Co-authored-by: Max Arturo <5713763+maxArturo@users.noreply.github.com>
Co-authored-by: Max Arturo <5713763+maxArturo@users.noreply.github.com>
Co-authored-by: Max Arturo <5713763+maxArturo@users.noreply.github.com>
@igalklebanov
Copy link
Contributor Author

@maxArturo Thanks again for the thorough review and great feedback! 💪

@feychenie
Copy link
Contributor

Hi @igalklebanov, there seems to be just a linting/prettier error preventing the merge :) Would be amazing if this could get in soon!

igalklebanov and others added 3 commits February 28, 2023 00:11
Co-authored-by: Frederik Eychenié <277455+feychenie@users.noreply.github.com>
@KennethHoff
Copy link

KennethHoff commented Mar 30, 2023

as suggested by @colinhacks

😢

(Although, I guess he did suggest it, I just created the issue about the general idea )

@igalklebanov
Copy link
Contributor Author

as suggested by @colinhacks

😢

(Although, I guess he did suggest it, I just created the issue about the general idea )

Did I do anything wrong? 🤷

@cyrusPIF
Copy link

Any updates on when this will be merged?

@sanfair sanfair mentioned this pull request Apr 21, 2023
@diego-escobedo
Copy link

Would be awesome to have this!!

@softcam-claiton
Copy link

Hello, any updates on when this will be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Date] Parsing of DateOnly strings