-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ZodString.date()
& ZodString.time()
.
#1766
Conversation
✅ Deploy Preview for guileless-rolypoly-866f8a ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @igalklebanov I promise I'm not following you 😆 I'm just going down the PRs to check them out!
👍 LGTM, just a couple of comments you may want to consider!
Co-authored-by: Max Arturo <5713763+maxArturo@users.noreply.github.com>
Co-authored-by: Max Arturo <5713763+maxArturo@users.noreply.github.com>
Co-authored-by: Max Arturo <5713763+maxArturo@users.noreply.github.com>
@maxArturo Thanks again for the thorough review and great feedback! 💪 |
Hi @igalklebanov, there seems to be just a linting/prettier error preventing the merge :) Would be amazing if this could get in soon! |
Co-authored-by: Frederik Eychenié <277455+feychenie@users.noreply.github.com>
d79d11c
to
10da48c
Compare
😢 (Although, I guess he did suggest it, I just created the issue about the general idea ) |
Did I do anything wrong? 🤷 |
Any updates on when this will be merged? |
Would be awesome to have this!! |
Hello, any updates on when this will be merged? |
Hey 👋
This PR resolves #1676, as suggested by @colinhacks @ comment.
ZodString.date()
.ZodString.time()
.