suggestions for effect plugin #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-smart
commented
Apr 27, 2024
| @@ -1,21 +1,20 @@ | |||
| import { Effect } from "effect"; | |||
| import * as Effect from "effect/Effect"; | |||
There was a problem hiding this comment.
alias imports are better for library code, as they cause less issues with bundlers
tim-smart
commented
Apr 27, 2024
| return error as z.ZodError; | ||
| }, | ||
| }); | ||
| return Effect.flatMap( |
There was a problem hiding this comment.
Effect.promise + flatMap allows us to use the safe apis
tim-smart
commented
Apr 27, 2024
| catch(error) { | ||
| return error as z.ZodError; | ||
| }, | ||
| return Effect.suspend(() => { |
There was a problem hiding this comment.
Effect.suspend allows us to wrap a side effect that returns an Effect, perfect for the sync api.
Merged
|
Thanks!! |
colinhacks
added a commit
that referenced
this pull request
May 3, 2024
* Update README_ZH.md (#3433) fix Demo -> Deno * Clean up code, fix build/test * Write docs * Fix rollup build * Fix setup-deno * Add types field * Fix types * Use globalThis check * Add _tag to ZodError * Comments * Add better tests * suggestions for effect plugin (#3449) * Updates * Move to .effect.parse() * Bind this in getter * Clean up --------- Co-authored-by: sdshaoda <21106848+sdshaoda@users.noreply.github.com> Co-authored-by: Tim <hello@timsmart.co>
colinhacks
added a commit
to ytsunekawa/zod
that referenced
this pull request
May 3, 2024
* Update README_ZH.md (colinhacks#3433) fix Demo -> Deno * Clean up code, fix build/test * Write docs * Fix rollup build * Fix setup-deno * Add types field * Fix types * Use globalThis check * Add _tag to ZodError * Comments * Add better tests * suggestions for effect plugin (colinhacks#3449) * Updates * Move to .effect.parse() * Bind this in getter * Clean up --------- Co-authored-by: sdshaoda <21106848+sdshaoda@users.noreply.github.com> Co-authored-by: Tim <hello@timsmart.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.