Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3437: extendShape erases JSDoc property documentation #3463

Merged
merged 1 commit into from
May 7, 2024

Conversation

jussisaurio
Copy link
Contributor

Fixes the issue described here, at least the minimal repro example provided.

Benchmarking the change using zod-ts-perftest it increases the number of type instantiations by 8.5%, which may be an acceptable compromise, but ofc not ideal

More discussion here

Copy link

netlify bot commented May 4, 2024

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 24d6ca4
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/6635e5d43c0aef00085d4e8a
😎 Deploy Preview https://deploy-preview-3463--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colinhacks colinhacks merged commit d969423 into colinhacks:master May 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants