Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed IP validation test #3809

Closed
wants to merge 1 commit into from

Conversation

wataryooou
Copy link
Contributor

@wataryooou wataryooou commented Oct 19, 2024

The tests started failing on the main branch after the following PR(#3513) was merged.

This PR removed this case from the test because a6ea::2454:a5ce:94.105.123.75 is not a valid IPv6 address.

Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 189c199
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/67135ab6db43ab00074702cd
😎 Deploy Preview https://deploy-preview-3809--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@m10rten m10rten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't try to sneak in changes outside the PR's description (fix IP validation) 😆

@wataryooou
Copy link
Contributor Author

This problem was resolved in this commit(f487d74).
Closed 🙏

@wataryooou wataryooou closed this Nov 10, 2024
@wataryooou wataryooou deleted the fix-test-ip-string branch November 10, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants