-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: add missing re-exports files and add new entries the published files #4500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update adds several new proxy files in the Changes
Sequence Diagram(s)sequenceDiagram
participant Consumer
participant ProxyModule (e.g. v4/core/index.js)
participant InternalModule (e.g. dist/esm/v4/core/index.js)
Consumer->>ProxyModule: import { X } from "zod/v4/core"
ProxyModule->>InternalModule: import { X } from "../../dist/esm/v4/core/index.js"
InternalModule-->>ProxyModule: export { X }
ProxyModule-->>Consumer: export { X }
Assessment against linked issues
Possibly related PRs
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
🔇 Additional comments (7)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (7)
packages/zod/package.json(1 hunks)packages/zod/v4/core/index.d.ts(1 hunks)packages/zod/v4/core/index.js(1 hunks)packages/zod/v4/locales/en.d.ts(1 hunks)packages/zod/v4/locales/en.js(1 hunks)packages/zod/v4/locales/index.d.ts(1 hunks)packages/zod/v4/locales/index.js(1 hunks)
🔇 Additional comments (6)
packages/zod/v4/locales/index.js (1)
1-1: Nice proxy setup here!
Soft proxy exporting from the ESM build looks correct and consistent with other v4 modules.packages/zod/v4/locales/en.d.ts (1)
1-2: Default & named re-exports look solid
You’re correctly forwarding all named exports and the default export from the dist declaration. Looks good for TS consumers.packages/zod/v4/locales/index.d.ts (1)
1-1: Double-check export target
This file inv4/localesre-exports fromcore/index.d.ts. Should it targetlocales/index.d.tsinstead? If it’s intentional, a quick note might help future readers.packages/zod/v4/core/index.js (1)
1-1: All good on the JS proxy
This mirrors the TS declaration proxy and correctly points to the ESM core build.packages/zod/v4/locales/en.js (1)
1-2: Proxy export looks solid. This module cleanly re-exports both all named exports and the default export from the compiled ESM build at../../dist/esm/v4/locales/en.js, making thev4/locales/en.jsentry point seamless for consumers.packages/zod/package.json (1)
7-7: Files array updated correctly. Including"v3","v4", and"v4-mini"here ensures your new versioned directories get packaged. Just double-check that the on-disk folder names exactly match these entries so nothing gets left out.
Follow up for #4489
fixes #4470
In that PR was missing:
filesarray in the package.json to make them part of the published packageTested on React Native 0.76.7 using the following snippet:
Summary by CodeRabbit
New Features
Chores