truncate support
#73
Closed
truncate support
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junjieqian
force-pushed
the
jqian/pr/truncate
branch
from
8b9ff08
to
7779883
Compare
|
Hey @junjieqian, This is great work, but I'm a bit worried about adding library support for a feature that's barely supported in the actual code - especially if that means we can't test it appropriately. If it's ok, I'd like to wait to merge this PR until 2.7 is better-supported in most or all the major distros. CDH6 seems like it should bump up to 2.7, at least. |
|
Hi @colinmarc , sure, let us hold this until 2.7 is supported in all the distros, 👍 . |
|
Can this PR be merged into the main branch now? We really need this feature. @colinmarc |
|
Can this PR be merged into master now? We really need this feature. @colinmarc |
colinmarc
force-pushed
the
jqian/pr/truncate
branch
10 times, most recently
from
f94d8fe
to
181da54
Compare
HDFS sometimes fails to close a file, indicating that the namenode has not yet recieved news from the datanodes that all data is flushed and replicated. In this case we should return an error to the client, so they know to retry.
colinmarc
force-pushed
the
jqian/pr/truncate
branch
from
181da54
to
535bcfd
Compare
|
Thanks @junjieqian! Merged in 2f11406. |
smkniazi
pushed a commit
to smkniazi/hopsfs-go-client
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to provide
truncatefeature. About the test:truncateyet (till Hadoop-2.7,truncateis supported).truncatetakes some time to be effective, and now a time delay (3 seconds, longer maybe safer) is added to the test. Not sure if we can find another better way for this, as the users may need to be aware this delay as well whentruncateis used.