Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload page component #18

Closed
colinmeinke opened this issue Feb 8, 2016 · 3 comments
Closed

Hot reload page component #18

colinmeinke opened this issue Feb 8, 2016 · 3 comments

Comments

@colinmeinke
Copy link
Owner

Currently is only rendered server-side so does not get hot reloaded.

@felixsanz
Copy link

Any progress on this? Also, i don't know how to make hot reloading work but no matter what i change (even components), webpack is not rebuilding anything. Probably because build and start are separate things.

So... first i build, and then i start the server, but "start" doesn't recompile on change

@colinmeinke
Copy link
Owner Author

Overhauling hot reloading is definitely on my radar. Probably as Dan mentions here #19

I am kind of holding off as HMR seems to be in flux at the moment, so was hoping someone comes up with the one true way of doing it.

You're correct though, HRM on this project seems to be temperamental, and often will not work. I have filed a bug about it where I think it is originating webpack/webpack-dev-middleware#68, but no response as of yet.

This specific issue is about reloading the Page component. This is particularly tricky as it is only rendered server side.

@felixsanz
Copy link

felixsanz commented Apr 14, 2016

Not sure if this is related, but my page have this tag:

<script type="text/javascript" charset="utf-8" src="/dist/0.96c731eaf327df44fc32.hot-update.js"></script>

I think thats appended automatically by webpack's entry: 'webpack-hot-middleware/client',.

The thing is, that js file (hot-update.js), if i try to open it, i get Internal Server Error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants