Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload Redux actions #19

Closed
colinmeinke opened this issue Feb 8, 2016 · 8 comments
Closed

Hot reload Redux actions #19

colinmeinke opened this issue Feb 8, 2016 · 8 comments

Comments

@colinmeinke
Copy link
Owner

No description provided.

@colinmeinke
Copy link
Owner Author

Reliant upon gaearon/babel-plugin-react-transform#26

@gaearon
Copy link

gaearon commented Feb 29, 2016

You might be interested in reduxjs/redux#1455.

@gaearon
Copy link

gaearon commented Apr 18, 2016

This is fixed in React Hot Loader 3.
It is built with lessons learned from both React Hot Loader and React Transform.
It’s still in alpha but I encourage you to check it out!

@colinmeinke
Copy link
Owner Author

Thanks Dan!

I've got it partially working 4478051

However updating actions or reducers hits me with the following error:

Uncaught TypeError: Cannot read property 'hot' of undefined

  getAffectedStuff @ client.js:351
  hotApply @ client.js:386
  (anonymous function) @ only-dev-server.js:32
  hotUpdateDownloaded @ client.js:312
  hotAddUpdateChunk @ client.js:284
  webpackHotUpdateCallback @ client.js:5
  (anonymous function) @ 0.4221176….hot-update.js:1

@gaearon
Copy link

gaearon commented Apr 20, 2016

Please file this with Webpack, it's an issue on their side. Might be possible to solve by updating it.

@colinmeinke
Copy link
Owner Author

Issue filed with Webpack webpack/webpack#2387

@gaearon
Copy link

gaearon commented Apr 24, 2016

I think it’s worth adding a stack trace there to make it clear why we think it’s a webpack issue.
Even better, a screenshot of the line where it crashes 😉 .

@colinmeinke
Copy link
Owner Author

Good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants