replace "DEL" Commands with "UNLINK". #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonashrem
changed the title
colinmollenhour
requested changes
Mar 19, 2021
There was a problem hiding this comment.
Thanks for the PR!
Changing the lua scripts requires updating the LUA_CLEAN_SH1 and LUA_GC_SH1 contants, though. It's been forever since I've had to do this.. @nemphys, what is your process for obtaining the new script hashes?
|
@colinmollenhour not anything fancy, I just add a temporary |
colinmollenhour
approved these changes
Jan 18, 2023
|
Finally merged! Sorry it took over 2 years... |
|
Thanks. I think we can close #158 than as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #158
This PR replaces DEL Command with UNLINK command like I suggested in #158
Details about UNLINK can be found here https://redis.io/commands/unlink .
As noticed here redis/redis#1748 (comment) this will not change the behavior.
As there is no check of Redis version included, it will break Redis Versions < 4.0 through.
As Redis 4.0 was released on 2017-07-14 and Redis 3 went EOL with the Redis 5 on 2018-10-17, I don't expect this being an issue.