Compatibility with latest versions of openmage #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @fballiano for making the PR. I did not test it yet since I think it's just a PHPStan error we are fixing, but I think it should work. The removing of submodules is because for our use-case we're installing via composer. I know at least the submodule in |
|
That was merged fast =) I guess @fballiano you can pull it into magento-lts and see if phpstan complains anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OpenMage/magento-lts#2138 we're trying to use this repo instead of the builtin version of Cm_RedisSession but it doesn't work because of OpenMage/magento-lts#1513
This PR should fix.
Probably it should be tagged as 3.0?