Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping #11

Merged
merged 32 commits into from
Oct 26, 2021
Merged

Housekeeping #11

merged 32 commits into from
Oct 26, 2021

Conversation

colinrobertbrooks
Copy link
Owner

@colinrobertbrooks colinrobertbrooks commented Oct 20, 2021 •
edited
Loading

Closes #8

Change Summary

Added:

Changed:

  • Peer dependency versions.

Release

This will be a patch version.

@colinrobertbrooks
Copy link
Owner Author

colinrobertbrooks commented Oct 20, 2021 •
edited
Loading

@kayluhb, would you be willing to give this a 👀 ? After this, I'm going to convert to TypeScript.

@kayluhb
Copy link
Collaborator

kayluhb commented Oct 21, 2021

@colinrobertbrooks Is the TS conversion going to be a part of this PR as well? Should I hold off on review until that work is complete?

@colinrobertbrooks
Copy link
Owner Author

colinrobertbrooks commented Oct 21, 2021 •
edited
Loading

@kayluhb, I was planning to do the TS conversion as a separate PR.

@colinrobertbrooks
Copy link
Owner Author

@kayluhb, the TS conversion is queued up in #12.

@amandapouget
Copy link

Will this merge soon?

I'm considering forking just to get the peer version upgrades.

kayluhb
kayluhb approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@kayluhb kayluhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did a fresh checkout and npm install and tests are running perfectly.

🚀 🚢 :shipit:

@colinrobertbrooks colinrobertbrooks merged commit fe0280e into master Oct 26, 2021
@colinrobertbrooks colinrobertbrooks deleted the housekeeping branch October 26, 2021 14:47
@colinrobertbrooks
Copy link
Owner Author

Released v3.2.2. 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayluhb kayluhb kayluhb approved these changes

Assignees
No one assigned
Labels
code reviewed tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update peer dependencies
3 participants
@colinrobertbrooks @kayluhb @amandapouget