-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn Off Devices via javascript? #12
Comments
Sounds good, I'll add something like |
stopDevice sounds good. |
Added |
Thanks , it is working. But i just upgraded to chrome 45 and getting depreciation Notices abobout MediaStream.stop() |
During audio-only mode : When i tried to stop and requestDevice , it just play the pre-recorded audio , didn't try to request device actually. Might be a bug. to test: //during AUDIO_ONLY
vjsrec.player().recorder.stopDevice();
vjsrec.player().recorder.getDevice(); |
Yeah, stop and get are not working as expected yet. I added a fix for the deprecation warnings, could you check what happens with an older version of Chrome? |
Because it turns out 4e07112 broke the Chrome check so a 0.9.1 should be released asap. |
I have no older version remained , just did os upgrade. I will check after downloading. |
It was also a little wonky in modes other than audio-only, should be better now. Now going to look at the audio-only issue. |
Tested with Chromium 32 on OSX and seems the fix for deprecation works there as well so releasing 0.9.1 now, but still need to fix the audio-only issue. |
this.getUserMedia(
this.mediaType,
this.onDeviceReady.bind(this),
this.onDeviceError.bind(this)); I tried replacing that in audio only . works partially , except it request media device two times and then fail to turnoff device. |
yeah i saw your PR but unfortunately the problem is a little further down the chain I think (in videojs-wavesurfer and/or wavesurfer.js microphone plugin). |
I think I have fixed it with 2efca39 but it also requires some changes in the wavesurfer.js microphone plugin that I'll open a pull request for. Once that wavesurfer change is released I can roll a new release I suppose. |
Did some more fixes (as well as in videojs-wavesurfer and wavesurfer.js), should be better when the microphone PR is merged: katspaugh/wavesurfer.js#542. |
If you upgrade to the latest wavesurfer.js (1.0.44) and microphone plugin, videojs-wavesurfer (0.9.9) and videojs-record 0.9.2 audio-only mode should work correctly. Please open a new ticket if there are new problems. |
Thanks alot . Testing tonight.
|
vjsplayer.recorder.stop()
only stop recording , so need another function for turning off camera .I don't want users to think that i am spying for NSA 😝
The text was updated successfully, but these errors were encountered: