Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio only implementation have stopped working #471

Closed
vora1993 opened this issue May 14, 2020 · 7 comments
Closed

Audio only implementation have stopped working #471

vora1993 opened this issue May 14, 2020 · 7 comments

Comments

@vora1993
Copy link

vora1993 commented May 14, 2020

Description

Audio only implementation is not working anymore

Steps to reproduce

Go to the following link and try to record audio:
https://collab-project.github.io/videojs-record/examples/audio-only.html

Results

Expected

Recorder should have recorded audio

Actual

Recorder is not recording audio and there is some error in console

Error output

image

@thijstriemstra
Copy link
Member

Ah yea, it's using videojs-wavesurfer 3.0.3 and that is not supported by videojs-record yet. I will pin videojs-wavesurfer to 2.11.0 on the website until then.

Thanks for the report.

@vora1993
Copy link
Author

vora1993 commented May 14, 2020

@thijstriemstra So it has stopped working for me locally too...What exact change should I do to make it work again?

@thijstriemstra
Copy link
Member

npm install --save videojs-wavesurfer@2.11.0

@thijstriemstra
Copy link
Member

thijstriemstra commented May 14, 2020

Installing videojs-record should not install v3.0.3 of videojs-wavesurfer, not sure how you ended up with a local videojs-wavesurfer v3.0.3.

Checking a fresh videojs-record installation, shows 2.11.0:

thijs@foo:/tmp$ mkdir test
thijs@foo:/tmp$ cd test/
thijs@foo:/tmp/test$ npm install videojs-record
npm WARN saveError ENOENT: no such file or directory, open '/tmp/test/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN notsup Unsupported engine for pkcs7@1.0.2: wanted: {"npm":"^1.4.6","node":"^0.10"} (current: {"node":"12.16.3","npm":"6.14.4"})
npm WARN notsup Not compatible with your version of node/npm: pkcs7@1.0.2
npm WARN enoent ENOENT: no such file or directory, open '/tmp/test/package.json'
npm WARN test No description
npm WARN test No repository field.
npm WARN test No README data
npm WARN test No license field.

+ videojs-record@3.11.0
added 34 packages from 31 contributors and audited 34 packages in 11.466s
found 0 vulnerabilities

thijs@foo:/tmp/test$ grep -R 'version' node_modules/videojs-wavesurfer/package.json 
"version": "2.11.0"

@thijstriemstra
Copy link
Member

If you clear browser cache and reload https://collab-project.github.io/videojs-record/examples/audio-only.html it should work again. Will now update the other audio-related examples.

@vora1993
Copy link
Author

vora1993 commented May 14, 2020

@thijstriemstra thanks for all your help...Actually I was using CDN like available in that example.
I have also now pinned it to 2.11.0 which solved my issue

@thijstriemstra
Copy link
Member

I will add a note to the readme as well.

thijstriemstra added a commit that referenced this issue May 14, 2020
videojs-wavesurfer v3.x is not supported yet.

refs #471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants