Revise examples and readme #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a user-friendly summary of all the example scripts due to somewhat convoluted names...
Add a table as well for fun.
Revise for nuance between hardcoded text entry versus user-entered text.
Proofread to remove some self-explanatory/redundant portions, thus saving space in the readme.
remove text_to_audio_file.py altogether since the minimal.py example already encompasses it. I created text_to_audio_file.py prior to being familiar with the "generate_to_file" method. Will do another commit formally removing the file altogether.
Deleting as redundant with minimal.py
Add commented lines to show how to easily test different models.
Revise readme.
Remove redundant import.
Remove redundant import.
Remove redundant import.
New example using text_to_playback method in pipeline.
Clarify that a user can specify a different file format and torchaudio's backend ```soundfile``` will automatically save it.
|
Any feedback or issues with this pull request? I just added a short comment in another commit today, just FYI. |
|
Hello? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry in advance for the multiple commits...I can revise and resubmit if necessary, but figured it's worth a shot...Most changes are to the readme and easily reviewable...