Update wiremock and switch from multipart to multer #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi64
reviewed
Feb 28, 2024
sjoerdsimons
force-pushed
the
sjoerd/update-dependencies
branch
from
637c4d3 to
252b311
Compare
Most of the changes are due to wiremock moving from http_types to the http crate. While there also change all return codes to use StatusCode values to make it more readable. Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
The multipart crate has been unmaintained for a while, replace with multer which e.g. also used by axum. Unfortunately multer is async only, while the wiremock Response trait is sync[0]. So that does require some hoops to jump through for now. 0: LukeMathWalker/wiremock-rs#84 Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
sjoerdsimons
force-pushed
the
sjoerd/update-dependencies
branch
from
252b311 to
86e4855
Compare
refi64
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump wiremock to 0.6 and replace multipart with multer as multipart is unmaintained