-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Folder" option filter portlet/tile #136
Draft
djay
wants to merge
30
commits into
main
Choose a base branch
from
djay/path_filters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djay
changed the title
path/section grouby in filter portlet
path/section groupby in filter portlet
Jul 12, 2021
@agitator any answers to the questions above? |
@petschki I've cleaned it all up and finalised the things I wasn't sure on. It's ready for a review. |
djay
changed the title
path/section groupby in filter portlet
"Folder" option filter portlet/tile
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How it works
The idea is to support documents that are already organised by folders with useful names and where heretical organisation might be needed.
Changes
I took the code from #26 and replaced the new section filter with an option in the existing filter portlet. It mostly does this by using new groupby_criteria defaults
Pros
Cons
Changes to groupby_criteria
Introduced the following changes to groupby_criteria overrides
Indenting
Alternatives
"Folder" as criteria name
When you pick the groupby it's called "Folder"
Pros
Cons
Alternatives