Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use always latest version of plone.api #699

Merged
merged 6 commits into from
Sep 14, 2018
Merged

Use always latest version of plone.api #699

merged 6 commits into from
Sep 14, 2018

Conversation

hvelarde
Copy link
Member

@hvelarde hvelarde commented Apr 4, 2017

@hvelarde hvelarde mentioned this pull request Apr 4, 2017
@hvelarde hvelarde force-pushed the plone_api branch 2 times, most recently from 537b873 to 930cb2a Compare June 13, 2017 02:24
@hvelarde hvelarde force-pushed the plone_api branch 2 times, most recently from cb9763d to 26f9db3 Compare June 16, 2017 14:12
@hvelarde hvelarde force-pushed the plone_api branch 4 times, most recently from 2392812 to 762b76c Compare December 18, 2017 14:30
@hvelarde hvelarde force-pushed the plone_api branch 3 times, most recently from 4dd215e to 0074332 Compare August 9, 2018 22:35
@hvelarde
Copy link
Member Author

hvelarde commented Aug 9, 2018

@idgserpro I need help here also; be aware of plone/plone.app.contenttypes#465.

@idgserpro
Copy link
Member

Does your workaround not work because of plone/plone.app.contenttypes#465?

@hvelarde
Copy link
Member Author

@idgserpro I really don't understand what's going on here: my guess is that the overly complicated architecture of plone.app.contenttypes making all content types depend on behavior is probably breaking things here.

it could be possible trying to access event.start attribute is not working without using an adapter, which really, really sucks.

# XXX: https://github.com/plone/plone.api/issues/364
plone.api = 1.6
# XXX: must be clean up after new Plone versions
plone.api = >=1.8.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not pin the specific version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll remove this later, for now we can test on latest version; anyway seems the release is a brown bag: buildout is failing with it:

$ bin/buildout 
Develop: '/home/hvelarde/collective/cover/.'
/home/hvelarde/.buildout/eggs/setuptools-26.1.1-py2.7.egg/pkg_resources/__init__.py:188: RuntimeWarning: You have iterated over the result of pkg_resources.parse_version. This is a legacy behavior which is inconsistent with the new version class introduced in setuptools 8.0. In most cases, conversion to a tuple is unnecessary. For comparison of versions, sort the Version instances directly. If you have another use case requiring the tuple, please file a bug with the setuptools project describing that need.
  stacklevel=1,
Unused options for buildout: 'show-picked-versions' 'package-min-coverage'.
Installing instance.
Getting distribution for 'plone.api==1.8.6'.
While:
  Installing instance.
  Getting distribution for 'plone.api==1.8.6'.
Error: Couldn't find a distribution for 'plone.api==1.8.6'.

CC @gforcada

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I see: it's 1.8.5 indeed.

@hvelarde hvelarde merged commit e016cde into master Sep 14, 2018
@hvelarde hvelarde deleted the plone_api branch September 14, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants