Issue_861

[Mubra]

closes #861

[scmos]

I just tried the change and it works correctly

[idgserpro]

First of all, thanks for this PR. (Just out of curiosity, which software are you using to create the gifs?)

Anyways. For this PR, it's a good pratice to:

• Add your change to https://github.com/collective/collective.cover/blob/master/CHANGES.rst. Always add your change to the last unreleased version, at the top (read the file to understand the references to issues as well);
• Create a test for this implementation using robot framework (an example https://github.com/collective/collective.cover/blob/master/src/collective/cover/tests/test_basic_tile.robot - read it to understand a bit of the syntax). We know this may seem overkill, since your change is just one line: but it's important to have a test suite to avoid breakage.

[scmos]

First of all, thanks for this PR. (Just out of curiosity, which software are you using to create the gifs?)

Anyways. For this PR, it's a good pratice to:

• Add your change to https://github.com/collective/collective.cover/blob/master/CHANGES.rst. Always add your change to the last unreleased version, at the top (read the file to understand the references to issues as well);
• Create a test for this implementation using robot framework (an example https://github.com/collective/collective.cover/blob/master/src/collective/cover/tests/test_basic_tile.robot - read it to understand a bit of the syntax). We know this may seem overkill, since your change is just one line: but it's important to have a test suite to avoid breakage.

• We are using https://www.screentogif.com/ for animated GIFs.
• The CHANGE.rst file we forget to update it, we will update it.
• The test in robot we are omitting because we do not know how to use it, we will review the tutorial to implement it in the future.

[Mubra]

Hi @idgserpro , the program I use is called 'ScreentoGif', I hope not to cause a problem, but if you like, I leave the link here https://www.screentogif.com/.

I will take these comments into account for my next PR

[idgserpro]

@Mubra, did @hvelarde invite you to the Collective Organization? If so, you can create branches directly in collecive/collective.cover.

[Mubra]

Ready, accept @hvelarde's invitation

[hvelarde]

please add an entry to the changelog so we can merge this.

[hvelarde]

please write a real changelog entry with useful information for integrators; there are plenty of examples below.

[idgserpro]

Also don't forget to put your userid under the entry.

[Mubra]

@idgserpro sorry, which 'ID' do you mean?

[idgserpro]

@idgserpro sorry, which 'ID' do you mean?

[Mubra]

see:

https://raw.githubusercontent.com/collective/collective.cover/master/CHANGES.rst

[hvelarde]

I'm going to approve it just to let you continue working; we need to improve this in the future.