Add schemaeditor support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, though I never use any of the TTW functionality. Could you provide a test for this so we don't accidentally break this feature in the future? |
|
Cool. It will take a while for me to find time for those tests, but I'll write them :) |
datakurre
force-pushed
the
datakurre-schemaeditor-support
branch
from
3fbc542 to
28cd392
Compare
|
This seems to work and has to be merged! |
|
@Martronic-SA as mentioned above, tests are still missing for this. @datakurre any update on this? |
|
I'm sorry, I forgot. Within the next few days :) |
|
Excellent, thank you :) |
|
@lukasgraf Done. |
|
@datakurre awesome, thank you! 🎉 🍰 |
|
@Martronic-SA released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could someone familiar with schema editor framework to verify that this is the correct way to register a schema editor feature for behavior.
How this should work:
0. When behavior is not enabled, nothing happens