Use batching on the saved data page. #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a client site I have a form with 12 questions and almost 700 entries and this takes over 40 seconds to load. Downloading the csv data takes just 4 seconds. By default the page now uses a batch size of 10. For good measure, you can override this by passing `?batch_size=x` in the url, but this gets lost when you use the batch navigation to go to the next page. This is because it is not supported by the standard `CrudBatchView` from `plone.z3cform`.
|
Apparently this was already done on 3.x in a nicer way: #368 |
|
I have released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a client site I have a form with 12 questions and almost 700 entries and this takes over 40 seconds to load. Downloading the csv data takes just 4 seconds.
By default the page now uses a batch size of 10.
For good measure, you can override this by passing
?batch_size=xin the url, but this gets lost when you use the batch navigation to go to the next page. This is because it is not supported by the standardCrudBatchViewfromplone.z3cform.