-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There's no upgradeStep for adding the collective.nitf tile if you're upgrading from 1.x to 2.x. #205
Labels
Comments
I think that has to be manually added in the upgrade step to |
We thought about 2000 because, in theory, this fix should be in the first available upgradeStep for 2.x branch (since the tile was added in 2.0a1), but if you think it's better to put in 2001 that's ok. |
sorry, I though the tile was added later; feel free to add it in |
idgserpro
added a commit
that referenced
this issue
Jun 30, 2017
hvelarde
pushed a commit
that referenced
this issue
Jul 3, 2017
hvelarde
pushed a commit
that referenced
this issue
Jul 3, 2017
hvelarde
pushed a commit
that referenced
this issue
Jul 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In https://github.com/collective/collective.nitf/tree/1.0b10/src/collective/nitf there wasn't a collective.nitf tile, added in https://github.com/collective/collective.nitf/blob/2.0a1/src/collective/nitf/tiles/nitf.pt, but there isn't an upgradeStep that adds this tile when you're upgrading from these major versions.
We suggest a fix in https://github.com/collective/collective.nitf/blob/master/src/collective/nitf/upgrades/v2000/profile/registry.xml, adding the same as https://github.com/collective/collective.nitf/blob/2.1b2/src/collective/nitf/profiles/default/registry.xml#L79 since there's no harm in adding an empty record like this if the user is not using plone.app.tiles.
The text was updated successfully, but these errors were encountered: