Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NITF tile for collective.cover #124

Merged
merged 1 commit into from
May 14, 2015
Merged

Add NITF tile for collective.cover #124

merged 1 commit into from
May 14, 2015

Conversation

hvelarde
Copy link
Member

closes #123

@hvelarde hvelarde force-pushed the issue_123 branch 2 times, most recently from c28e89b to 0f0f07d Compare May 13, 2015 21:00
@@ -77,4 +77,10 @@
<value key="group" i18n:translate="">NITF</value>
</records>

<record name="plone.app.tiles">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hvelarde is it possible to add any condition here if collective.nitf is installed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, but... collective.nitf is installed :-)

what we need is to remove that at uninstall time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I misunderstand it..

@hvelarde hvelarde force-pushed the issue_123 branch 2 times, most recently from 69ed1af to 6ede10f Compare May 14, 2015 18:29
@rodfersou
Copy link
Member

Please update the changelog

@hvelarde
Copy link
Member Author

you were waiting for this for a long time, didn't you ;-)

rodfersou added a commit that referenced this pull request May 14, 2015
Add NITF tile for collective.cover
This branch closes #123
@rodfersou rodfersou merged commit bbea4bb into master May 14, 2015
@rodfersou
Copy link
Member

yes sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a tile for use in collective.cover
2 participants