-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTC-fix + zoneinfo-fix #339
Conversation
@tobixen thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
Uff - the failures now is due to the last bugfix, fixing a bug in the new test code. |
@jenkins-plone-org please run jobs Trying to rerun tests ... as I still believe the test breakages are arbitrary and not related to my changes |
@tobixen , we are in the process of setting up maintenance for this repository again, see #360. It will take some time but I hope, we will get further towards integrating your changes. Thanks a lot for the effort and patience already! |
Pull Request Test Coverage Report for Build 2898736507
💛 - Coveralls |
Thanks @tobixen! That is a nice PR with a lot of tests! |
This is a combination of merge request #334 and merge request #337.
If all tests pass, then it must be a temporarily glitch that merge request #334 didn't pass.
If there are the same test failures as in request #334, then ... probably that merge request breaks plone somehow.
Sorry for the flood of merge-requests. Don't know how to run those plone tests. I'm just interested in the icalendar library :-)