Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTC-fix + zoneinfo-fix #339

Merged
merged 11 commits into from
Aug 21, 2022
Merged

UTC-fix + zoneinfo-fix #339

merged 11 commits into from
Aug 21, 2022

Conversation

tobixen
Copy link
Contributor

@tobixen tobixen commented Nov 17, 2021

This is a combination of merge request #334 and merge request #337.

If all tests pass, then it must be a temporarily glitch that merge request #334 didn't pass.

If there are the same test failures as in request #334, then ... probably that merge request breaks plone somehow.

Sorry for the flood of merge-requests. Don't know how to run those plone tests. I'm just interested in the icalendar library :-)

@mister-roboto
Copy link

@tobixen thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@tobixen
Copy link
Contributor Author

tobixen commented Nov 17, 2021

@jenkins-plone-org please run jobs

@tobixen
Copy link
Contributor Author

tobixen commented Nov 17, 2021

@jenkins-plone-org please run jobs

@tobixen
Copy link
Contributor Author

tobixen commented Nov 17, 2021

Uff - the failures now is due to the last bugfix, fixing a bug in the new test code.

@tobixen
Copy link
Contributor Author

tobixen commented Nov 18, 2021

@jenkins-plone-org please run jobs

Trying to rerun tests ... as I still believe the test breakages are arbitrary and not related to my changes

@niccokunzmann
Copy link
Member

@tobixen , we are in the process of setting up maintenance for this repository again, see #360. It will take some time but I hope, we will get further towards integrating your changes. Thanks a lot for the effort and patience already!
If you like to run the latest tests for this PR, you can rebase/merge master.

@coveralls
Copy link

coveralls commented Aug 21, 2022

Pull Request Test Coverage Report for Build 2898736507

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 91.003%

Totals Coverage Status
Change from base Build 2897629571: 0.1%
Covered Lines: 1143
Relevant Lines: 1256

💛 - Coveralls

@niccokunzmann niccokunzmann merged commit 42e039c into collective:master Aug 21, 2022
@niccokunzmann
Copy link
Member

Thanks @tobixen! That is a nice PR with a lot of tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TZID emissions don't match timezone names, but may later result in a timezone name lookup
4 participants