Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add badges for download and PyPI version #365

Merged
merged 2 commits into from
Aug 13, 2022

Conversation

niccokunzmann
Copy link
Member

It adds two badges.


shows which version is there - quite useful to know and nice to see that it changes after deploy


makes sure we know that this is important and used a lot!

@geier
Copy link
Collaborator

geier commented Aug 9, 2022

While we are at it, should we remove the Travis Badge and also add a github workflow badge?

@coveralls
Copy link

coveralls commented Aug 9, 2022

Pull Request Test Coverage Report for Build 2814362254

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.758%

Totals Coverage Status
Change from base Build 2684673460: 0.0%
Covered Lines: 1149
Relevant Lines: 1266

💛 - Coveralls

@geier
Copy link
Collaborator

geier commented Aug 9, 2022

Sorry, only saw #364 now.

@niccokunzmann
Copy link
Member Author

niccokunzmann commented Aug 9, 2022 via email

@geier
Copy link
Collaborator

geier commented Aug 9, 2022

@niccokunzmann this now conflicts, do you want to resolve or should I?

@niccokunzmann
Copy link
Member Author

niccokunzmann commented Aug 11, 2022 via email

@mauritsvanrees mauritsvanrees merged commit d8b8cf4 into collective:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants