-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove any syntax required for python < 3.8 #376
Conversation
find . -iname "*.py" -exec pyupgrade --py38-plus {} \;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay. Thanks. I guess compat.py
can be removed now, like you did on your PR #327.
Waiting on an answer to my recent question there.
It can likely be remove. This PR is purely autogenerated, hence the reason to keep it all separate.
|
I would wait until #368 is merged so we know if we want to drop Python 3.7 already.
Cool! That might also work for Python 3.7 if needed. Thanks for showing that, I did not know it existed! |
If you want to keep 3.7 around for now, I can just redo the PR using:
|
@WhyNotHugo #368b has been merged. Would you like to make a new PR for py37? |
As far as I can tell,
I've created a PR for the 4.x branch, see: #384 |
@WhyNotHugo thanks for your effort - I just ran the tests for Python3.7 and it works with this PR. I think, you can close #384 and we will merge this one...
|
> find . -iname "*.py" -exec pyupgrade --py38-plus {} \;