Test restructure - test_restructure_issue_55 #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3121789081
💛 - Coveralls |
jacadzaca
force-pushed
the
test_restructure_issue_55
branch
from
54cfb78 to
8a3d665
Compare
src/icalendar/tests/test_parsing.py
Outdated
| 'issue_55_parse_error_on_utc_offset_with_seconds', | ||
| ]) | ||
| def test_timezones_to_ical_is_inverse_of_from_ical(timezones, timezone_file): | ||
| timezone = getattr(timezones, timezone_file) |
There was a problem hiding this comment.
If you add a getitem method - should be the same as getattr, then this is a one-liner.
Would you like to do that?
jacadzaca
force-pushed
the
test_restructure_issue_55
branch
from
dc599c3 to
e24a965
Compare
|
merging as the tests work now |
|
Thanks again for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitting as per #400