Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test restructure issue 70 #406

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Test restructure issue 70 #406

merged 2 commits into from
Sep 24, 2022

Conversation

jacadzaca
Copy link
Collaborator

splitting as per #400

@coveralls
Copy link

coveralls commented Sep 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3090244992

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.759%
Totals Coverage Status
Change from base Build 3076288048: -0.1%
Covered Lines: 1153
Relevant Lines: 1243
💛 - Coveralls

@jacadzaca jacadzaca force-pushed the test_restructure_issue_70 branch from a9bedae to fdd275a Compare September 20, 2022 12:39
niccokunzmann
niccokunzmann reviewed Sep 24, 2022
View reviewed changes
src/icalendar/tests/test_parsing.py
from icalendar import vRecur

def test_decode_rrule_attribute_error_issue_70(events):
# Issue #70 - e.decode("RRULE") causes Attribute Error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ususally, this would appear in a string - why is that different?

@niccokunzmann niccokunzmann merged commit 99b2be8 into collective:master Sep 24, 2022
@niccokunzmann
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niccokunzmann niccokunzmann niccokunzmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacadzaca @coveralls @niccokunzmann