Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor test_issue_345 #415

Merged
merged 4 commits into from
Sep 28, 2022
Merged

refactor test_issue_345 #415

merged 4 commits into from
Sep 28, 2022

Conversation

jacadzaca
Copy link
Collaborator

splitting as per #400

@coveralls
Copy link

coveralls commented Sep 20, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3089973912

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.891%
Totals Coverage Status
Change from base Build 3076288048: 0.0%
Covered Lines: 1176
Relevant Lines: 1266
💛 - Coveralls

niccokunzmann
niccokunzmann requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@niccokunzmann niccokunzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests would need to be added to be sure that future changes do not break dependent code.

src/icalendar/tests/test_fixed_issues.py
"""Issue #345 - Why is tools.UIDGenerator a class (that must be instantiated) instead of a module? """
uid1 = icalendar.tools.UIDGenerator.uid()
uid2 = icalendar.tools.UIDGenerator.uid('test.test')
uid3 = icalendar.tools.UIDGenerator.uid(unique='123')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are missing these cases:

  • one argument host_name
  • one argument unique
  • no arguments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I create a PR for that...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jacadzaca#2

@niccokunzmann
Copy link
Member

Thanks for your pull request! I saw through it and created a PR adding to the changes. jacadzaca#2 Please review :)

@jacadzaca
Merge pull request #2 from niccokunzmann/jacadzaca-test_restructure_i…
a580f2e 
…ssue_345

Jacadzaca test restructure issue 345
@niccokunzmann niccokunzmann merged commit 5d4e580 into collective:master Sep 28, 2022
@niccokunzmann
Copy link
Member

Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niccokunzmann niccokunzmann niccokunzmann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacadzaca @coveralls @niccokunzmann