Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for RDATE with PERIOD value #456

Merged
merged 6 commits into from
Oct 15, 2022
Merged

add tests for RDATE with PERIOD value #456

merged 6 commits into from
Oct 15, 2022

Conversation

niccokunzmann
Copy link
Member

@niccokunzmann niccokunzmann commented Oct 13, 2022 •
edited
Loading

fixes #156

This tests that

  • the RDATE of type PERIOD is put back into ICS
  • the values provided are indeed correct

@niccokunzmann niccokunzmann added tested and needs fix This pull request tests code but needs a contribution to fix the test - TDD needs 4.x PR too This pull request contributes to 'master' and as a security or bug fix remains to go into '4.x' labels Oct 13, 2022
@niccokunzmann niccokunzmann mentioned this pull request Oct 13, 2022
Closed
@niccokunzmann
Copy link
Member Author

niccokunzmann commented Oct 13, 2022 •
edited
Loading

For some reason, the duration looses its minutes:
https://github.com/collective/icalendar/actions/runs/3244748413/jobs/5321333702#step:6:60
This is the output:

'RDATE;VALUE=PERIOD:19970101T180000Z/19970102T070000Z,19970109T180000Z/PT5H' != 
'RDATE;VALUE=PERIOD:19970101T180000Z/19970102T070000Z,19970109T180000Z/PT5H30M'

@niccokunzmann niccokunzmann removed tested and needs fix This pull request tests code but needs a contribution to fix the test - TDD needs 4.x PR too This pull request contributes to 'master' and as a security or bug fix remains to go into '4.x' labels Oct 13, 2022
@jacadzaca jacadzaca merged commit b77922e into master Oct 15, 2022
@niccokunzmann niccokunzmann deleted the issue-156-rdate-with-period branch October 17, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better support for RDATE with VALUE=PERIOD
2 participants
@niccokunzmann @jacadzaca