-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs folder #720
Add docs folder #720
Conversation
@mgorny, I had a look and it turns out the fix is simple. |
Pull Request Test Coverage Report for Build 11306099255Details
💛 - Coveralls |
Thanks! |
@stevepiercy would you like to have a review look? You like the docs, too :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like grammatically correct sentences using the past verb tense in change log notes, because after publication it will be in the past.
Also I like error messages to tell me both what the problem is and what explicit action I need to do next to resolve it.
Thanks for asking for my review.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@stevepiercy thanks for the review! I agree with the error messages being more of a guide. When it comes to the changelog. My reasoning behind present tense is this: In some practice, commits are formulated in this way: I value the contribution, contributions from a diverse background are divers. Asking to conform and make lots of changes might not be as inclusive when it comes to time invested voluntarily - that is my reasoning when it comes to external and first-time contributions. In the team, we can agree on disciplines for us:) Feel free to merge as I would not add anything... I just have to wait for 1 week to merge my own PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the explanation of change log policy.
fixes #712
📚 Documentation preview 📚: https://icalendar--720.org.readthedocs.build/