Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start calculating event start and end #721

Merged

Conversation

niccokunzmann
Copy link
Member

@niccokunzmann niccokunzmann commented Oct 10, 2024

This is a contribution to #662.

Calculation of event start and end are actually quite complex.

This also contributes to #716 because the calculation of start and end are way easier then.


📚 Documentation preview 📚: https://icalendar--721.org.readthedocs.build/

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use some narrative docs, too.

CHANGES.rst Outdated Show resolved Hide resolved
src/icalendar/cal.py Outdated Show resolved Hide resolved
src/icalendar/cal.py Outdated Show resolved Hide resolved
src/icalendar/cal.py Show resolved Hide resolved
niccokunzmann and others added 5 commits October 11, 2024 12:26
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@coveralls
Copy link

coveralls commented Oct 11, 2024

Pull Request Test Coverage Report for Build 11306091038

Details

  • 327 of 336 (97.32%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 97.336%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/icalendar/cal.py 118 120 98.33%
src/icalendar/tests/test_issue_662_component_properties.py 207 214 96.73%
Totals Coverage Status
Change from base Build 11199956195: -0.05%
Covered Lines: 3500
Relevant Lines: 3592

💛 - Coveralls

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo and minor rewording of docstring. Otherwise, LGTM!

src/icalendar/cal.py Outdated Show resolved Hide resolved
src/icalendar/cal.py Outdated Show resolved Hide resolved
niccokunzmann and others added 2 commits October 12, 2024 14:35
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niccokunzmann niccokunzmann merged commit 1907deb into collective:main Oct 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants