-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support python 3.13 #729
Support python 3.13 #729
Conversation
@Firdous2307 Thanks! I wonder why there are no merge conflicts.. I will update the branch. Could you fix the changelog? The last change was in the already released version. |
Pull Request Test Coverage Report for Build 11364486897Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@niccokunzmann no problem , I have fixed the changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added a few comments to clear possible confusion about what I meant. 6.0.1 is already released. We cannot change the changelog for that except take that one line about 3.13 out that was accidentally not in 6.0.2 but added to 6.0.1.
CHANGES.rst
Outdated
|
||
Breaking changes: | ||
|
||
- ... | ||
|
||
New features: | ||
|
||
- ... | ||
|
||
Bug fixes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines need to stay... That is where people fill things in until we release.
CHANGES.rst
Outdated
------------------ | ||
|
||
New features: | ||
|
||
- Added ``Event.end``, ``Event.start``, ``Event.dtstart``, and ``Event.dtend`` attributes. See `Issue 662 <https://github.com/collective/icalendar/issues/662>`_. | ||
- Test compatibility with Python 3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would need removing
Thanks for working on it! It is nice for me to collaborate instead of doing it myself! I hope I learn to be better at communicating this way, too :) |
Please let me know when you would like me to review/merge! |
Thank you! Glad you're enjoying the collaboration. You're doing great, and it only gets better with practice! 😊 |
@niccokunzmann It's ready for review!! |
1 similar comment
@niccokunzmann It's ready for review!! |
Please have a look at the changelog file your changes should be added to the top heading: https://github.com/collective/icalendar/blob/main/CHANGES.rst Everything else would be left untouched - except for the change for 3.13 that landed in the wrong release. |
Co-authored-by: Nicco Kunzmann <niccokunzmann@rambler.ru>
Hm... No problem if you want to not spend so much time just on the changelog... I create a PR for you .... |
I could not create a PR but I could commit directly. I think, #730 (comment) is valid for this PR, though, could you use the proper RST way and then, I think, it is fine to merge! |
The changes in this PR do not do what the description says. |
@stevepiercy I think that is ok. @Firdous2307 is contributing for the first time and it does not need to be too perfect. This is a follow-up PR from the on made already to close #723. In that sense, it is not too bad. We had the changes in here but they were removed because of duplication. |
@niccokunzmann Any more changes needed to make? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will apply these changes and merge it. Thanks!
@niccokunzmann You are welcome, had a fun experience working on this issue |
@Firdous2307 Thanks for your work! I squashed the commits into one and so you will need to start from collective/icalendar's main branch for new PRs. |
If you are doing the hacvktoberfest, have a look if this shows up as a contribution - it should. If it does not , let me know :) |
@niccokunzmann Yes I am, ideally it shows up as a contribution but they review it in 7 days. I will keep you posted on it. |
Add support for Python 3.13
This PR adds support for Python 3.13 to the icalendar project. It includes updates to the test configurations, project metadata, and documentation.
Changes made:
Documentation:
docs/maintenance.rst
about updating Python versionsThis PR addresses issue #723.
📚 Documentation preview 📚: https://icalendar--729.org.readthedocs.build/