Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Security Policy #755

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Breaking changes:

New features:

- ...
- Add :ref:`Security Policy`

Bug fixes:

Expand Down
8 changes: 4 additions & 4 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ For pull requests, keep this in mind

- Add a test which proves your fix and make it pass.

- Describe your change in CHANGES.rst
- Describe your change in ``CHANGES.rst``

- Add yourself to the docs/credits.rst
- Add yourself to the ``docs/credits.rst``

Development Setup
-----------------
Setup for Development
---------------------

If you would like to setup icalendar to
contribute changes, the `Installation Section
Expand Down
7 changes: 7 additions & 0 deletions SECURITY.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Security Policy

Please find our [security policy in the documentation](https://icalendar.readthedocs.io/en/latest/security.html).

See also:

- [docs/security.rst](docs/security.rst)
4 changes: 3 additions & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
'sphinx.ext.autodoc',
'sphinx.ext.coverage',
'sphinx.ext.viewcode',
'sphinx_copybutton'
'sphinx_copybutton',
'sphinx.ext.intersphinx',
'sphinx.ext.autosectionlabel',
]
source_suffix = '.rst'
master_doc = 'index'
Expand Down
2 changes: 0 additions & 2 deletions docs/contributing.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
.. _contributing:

------------------
Contributing
------------------
Expand Down
1 change: 1 addition & 0 deletions docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@ Contents
:titlesonly:

contributing
security
58 changes: 58 additions & 0 deletions docs/security.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a security policy, see examples at:

It's really up to you what you want to include. If you have another revision after reviewing the above items, please @ me and I'll take another look. I'd suggest incorporating some bits and pieces from the above, especially how to work with CVEs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the links! I changed it to link to the Plone security page.

I will also write to the security team to ask if they have any feedback on this change.

Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
Security Policy
===============

This documents the security policy and actions to take to secure the package and its deployment and use.

Supported Versions
------------------

Security vulnerabilities are fixed only for the latest version of ``icalendar``.

.. list-table:: Versions to receive security updates
:widths: 25 25
:header-rows: 1

* - Version
- Supported
* - 6.*
- YES
* - 5.*
- no
* - 4.*
- no
* - before 4.*
- no


Reporting a Vulnerability
-------------------------

To report security issues of ``collective/icalendar``, use the ``Report a vulnerability`` button on the project's `Security Page <https://github.com/collective/icalendar/security>`_.
niccokunzmann marked this conversation as resolved.
Show resolved Hide resolved
If you cannot do this, please contact one of the :ref:`maintainers` directly.

The maintainers of ``icalendar`` will then notify `Plone's security team <https://plone.org/security/report>`_.

If we determine that your report may be a security issue with the project, we may contact you for further information.
We volunteers ask that you delay public disclosure of your report for at least ninety (90) days from the date you report it to us.
This will allow sufficient time for us to process your report and coordinate disclosure with you.

Once verified and fixed, the following steps will be taken:

- We will use GitHub's Security Advisory tool to report the issue.
- GitHub will review our Security Advisory report for compliance with Common Vulnerabilities and Exposures (CVE) rules.
If it is compliant, they will submit it to the MITRE Corporation to generate a `CVE <https://www.cve.org/>`_.
This in turn submits the CVE to the `National Vulnerability Database (NVD) <https://nvd.nist.gov/vuln/search>`_.
GitHub notifies us of their decision.
- Assuming it is compliant, we then publish our Security Advisory on GitHub, which triggers the next steps.
- GitHub will publish the CVE to the CVE List.
- GitHub will broadcast our Security Advisory via the `GitHub Advisory Database <https://github.com/advisories>`_.
- GitHub will send `security alerts <https://docs.github.com/en/code-security/supply-chain-security/managing-vulnerabilities-in-your-projects-dependencies/about-alerts-for-vulnerable-dependencies>`_ to all repositories that use our package (and have opted into security alerts).
This includes Dependabot alerts.
- We will make a bug-fix release.
- We will send an announcement through our usual channels:

- The :ref:`Changelog`
- The GitHub releases of ``icalendar``
- If possible also `Plone's Security Announcements <https://plone.org/security/announcements>`_

- We will provide credit to the reporter or researcher in the vulnerability notice.
Loading