Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #98

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Add support for Python 3.12 #98

merged 1 commit into from
Jan 26, 2024

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Jan 23, 2024

No description provided.

@pbauer pbauer requested a review from mauritsvanrees January 23, 2024 14:01
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two remarks, but fine to merge without changes.

"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be fine with dropping the EOL 3.7. But this is optional.

@pbauer pbauer merged commit 4187ec5 into master Jan 26, 2024
@mauritsvanrees mauritsvanrees deleted the python312 branch February 29, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants