Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions #97

Merged
merged 9 commits into from
Aug 18, 2023
Merged

github actions #97

merged 9 commits into from
Aug 18, 2023

Conversation

mamico
Copy link
Contributor

@mamico mamico commented Aug 11, 2023

see #90

  • add tox
  • add github actions (test + lint)
  • make tests happy
  • add coverage/coveralls
  • cleanup (travis configs, badges, ...)

tox -e py27 works locally, I don't know if it is a good idea to work so that it can also work on github.

@fredvd
Copy link
Member

fredvd commented Aug 11, 2023

@mamico Thanks for picking this up. the challenge with Python 2.7 support will be that github itself is deprecating or already has deprecated generic 2.7 support. Looking up.. has removed: actions/setup-python#672

So I'm not sure if we should still put the effor here in Python 2.7. Could Plone/meta help here as well?

@mauritsvanrees
Copy link
Member

I would say: drop 2.7 support. Only support 3.8-3.11. Testing on 3.8 and 3.11 should be enough. Or start with only one Python.

We would be dropping support in a bugfix release, but that is because we chose to have the package version start with the Varnish version we support.

@mauritsvanrees
Copy link
Member

I am not sure if coverage will work. I think I have seen problems years ago when I tried it on a buildout recipe, and lots of code was not picked up because coverage could not detect that this code was being run. Your mileage may vary.

For me, coverage is not needed. But sure, if it can be done, then it can be used to keep the coverage at a minimum level.

@mamico
Copy link
Contributor Author

mamico commented Aug 11, 2023

The tests are already running for py38 to py311, py27 run locally (if needed).

I will check for coverage.

@mamico
Copy link
Contributor Author

mamico commented Aug 11, 2023

@mauritsvanrees I confirm your experience. IMO the coverage does not detect code that is executed during system calls (ie system(bin/buildout)).

We can re-evaluate this in the future, for now I'll stop here.

@mamico mamico marked this pull request as ready for review August 11, 2023 19:49
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@mauritsvanrees mauritsvanrees merged commit 9a6d4dd into master Aug 18, 2023
5 checks passed
@mauritsvanrees
Copy link
Member

I have released 6.0.11 with this.
I needed to remove the towncrier config first, because it was not working. See commit 9fea808. You can restore it now if you want, and add a news/.gitkeep file, and some lines of explanation in CHANGES.rst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants